> On Nov. 7, 2017, 5:09 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 319 (patched) > > <https://reviews.apache.org/r/63175/diff/1/?file=1864532#file1864532line319> > > > > I think this should be `connected`? > > > > Right now there's some confusion around `active` and `connected`. > > `active` in the past meant that the framework was receiving offers, but we > > never added the ability for frameworks to change this state. When we added > > suppression, that was equivalent to deactivation (note that activation has > > become a per-role thing). > > > > Mostly `connected` == `active`. But I think the point of this boolean > > is to track whether we can talk to the framework? Thoughts? > > Jiang Yan Xu wrote: > `active` is already used in the class and this review doesn't change its > meaning so I think we can defer this for later? > > For activeness vs. connectedness, I feel it's a larger effort to address > it consistently. I'll follow up on this.
And we'd better keep it consistent between master and allocator, [agents](https://github.com/apache/mesos/blob/94ef10c2d4572cbe8c70b40fe3c59524186d6236/src/master/master.hpp#L196-L202) and frameworks, method names ([e.g.](https://github.com/apache/mesos/blob/94ef10c2d4572cbe8c70b40fe3c59524186d6236/src/master/allocator/mesos/hierarchical.hpp#L123)) and variables Right? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63175/#review190412 ----------------------------------------------------------- On Nov. 7, 2017, 5:02 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63175/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 5:02 p.m.) > > > Review request for mesos, Benjamin Mahler, James Peach, and Joseph Wu. > > > Bugs: MESOS-8085 > https://issues.apache.org/jira/browse/MESOS-8085 > > > Repository: mesos > > > Description > ------- > > Do not generate UnavailableResources for inactive frameworks. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2f7755afd056455ce6bddfbe2619a359f41d8e6a > src/master/allocator/mesos/hierarchical.cpp > f0f1111a7754e5968288edb15929efc9d244b177 > > > Diff: https://reviews.apache.org/r/63175/diff/2/ > > > Testing > ------- > > make check. > > I didn' write a new test as the externally observable behavior doesn't change. > > > Thanks, > > Jiang Yan Xu > >
