-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63781/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Jie Yu.
Bugs: MESOS-7305
https://issues.apache.org/jira/browse/MESOS-7305
Repository: mesos
Description
-------
The change in the return type for Containerizer::launch has less of an
impact on the Docker containerizer, as it (currently) will not return
the "new" enum 'ALREADY_LAUNCHED'.
Note that in changing Containerizer::launch, a private helper of the
Docker containerizer `reapExecutor`s return value was changed.
The return value was originally `Future<bool>` because `reapExecutor`
is the final continuation in the launch path so it needed to match
the return value of Containerizer::launch. However, `reapExecutor`
never returns `false` (only `true` or a Failure).
Diffs
-----
src/slave/containerizer/docker.hpp b602a5698cae12686f51c4b9370a06042cda6270
src/slave/containerizer/docker.cpp 292eecbca246edf068ec8c262aff4f3ce9cd8c67
Diff: https://reviews.apache.org/r/63781/diff/1/
Testing
-------
Requires the next review in the chain (test changes).
Thanks,
Joseph Wu
