----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63555/#review190572 -----------------------------------------------------------
src/slave/slave.hpp Lines 538 (patched) <https://reviews.apache.org/r/63555/#comment268051> What's the motivation for this `extra` parameter? It isn't used anywhere, probably we should remove it. src/slave/slave.cpp Lines 6816-6822 (patched) <https://reviews.apache.org/r/63555/#comment268052> So this will try to publish all RP resources of all executor of all frameworks? Or am I missing something here? I'd expect that only the RP resources of the task/executor that's about to get started should be published. Hence `resourceProviderManager->publish(info.id(), executor->allocatedResources())` should be enough. - Jan Schlicht On Nov. 4, 2017, 2:55 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63555/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2017, 2:55 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Joseph Wu, and Jan Schlicht. > > > Bugs: MESOS-7550 > https://issues.apache.org/jira/browse/MESOS-7550 > > > Repository: mesos > > > Description > ------- > > `Slave::publishAllocatedResources()` will compute the total allocated > resources for all currently running executor containers, and takes an > `extra` argument for resources that will be used by the executor that > is about to launch, then sums them up and asks the resource provider > manager to publish the resources. > > > Diffs > ----- > > src/slave/slave.hpp df1b0205124555dcb6a0efa5c237f5e77fa2bdf7 > src/slave/slave.cpp 337083dbe60bba2d3773b785bdceeaf0b8fcd070 > > > Diff: https://reviews.apache.org/r/63555/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
