----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63058/#review190478 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Nov. 2, 2017, 4:01 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63058/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 4:01 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7305 > https://issues.apache.org/jira/browse/MESOS-7305 > > > Repository: mesos > > > Description > ------- > > By default, the HTTP handlers in libprocess will translate failures > (of returned Futures) into '500 Internal Server Error'. This commit > only changes the `LAUNCH_NESTED_CONTAINER` and `LAUNCH_CONTAINER` APIs > to return '400 Bad Request' instead when the container launch fails, > as it is more likely for the failure to be a user-input error. > > > Diffs > ----- > > src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b > src/tests/agent_container_api_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/63058/diff/2/ > > > Testing > ------- > > make check > > On... > OSX and Ubuntu 16 > > > Thanks, > > Joseph Wu > >
