> On Nov. 6, 2017, 11:51 p.m., Greg Mann wrote: > > src/messages/messages.cpp > > Lines 42-46 (patched) > > <https://reviews.apache.org/r/63495/diff/1/?file=1878575#file1878575line42> > > > > You could simply do > > ``` > > return left.uuid() == right.uuid(); > > ``` > > but not a big deal; feel free to drop this issue if you desire.
I follow a general pattern here where we return `false` if any equality check fails, `true` otherwise. This particular pattern has the advantage of being trivially extensible should we add more fields (unlikely here though). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63495/#review190239 ----------------------------------------------------------- On Nov. 2, 2017, 2:57 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63495/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 2:57 a.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Added comparison operators for 'ResourceVerionUUID'. > > > Diffs > ----- > > src/messages/messages.hpp 59e670532c8eb1ab1ec6cb063ace03481cd6a33d > src/messages/messages.cpp 7f1da63ae67b3918851c2c1dd225bfd2d0044387 > > > Diff: https://reviews.apache.org/r/63495/diff/1/ > > > Testing > ------- > > `make check`, additional testing as part of > https://reviews.apache.org/r/63496/. > > > Thanks, > > Benjamin Bannier > >
