> On Nov. 6, 2017, 10:47 p.m., Benjamin Bannier wrote: > > I confirmed that just running clang-tidy with > > `google-readability-redundant-smartptr-get` and `-fix` does produce this > > patch. I did however run into trouble building this patch on top of > > `de19f7381108d491fb41fe3d8ae13e9893213bbc`. Could you make sure it compiles > > yet still produces no diagnostics?
Something was wrong with my build dir, everything looking good. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63568/#review190224 ----------------------------------------------------------- On Nov. 6, 2017, 7:59 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63568/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 7:59 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > ``` > 3rdparty/libprocess/src/../include/process/owned.hpp:117:7: > warning: redundant get() call on smart pointer > [google-readability-redundant-smartptr-get] > ``` > > > Diffs > ----- > > src/master/http.cpp fa0f60cad1f699886df1163ecfd2e34f9154d77f > src/master/master.cpp f349fec8b61fa424c63d77253b6ab3ded08c8cdb > src/slave/http.cpp f2e06aff95e0628624b6ed25de222fd3f3577a0b > src/slave/slave.cpp 79ee163b41ade93cae1054985379d61faf6a081a > src/tests/authorization_tests.cpp f65bf2f89b5c22fb6f366cf3998713f48b52dcd7 > src/tests/containerizer/cni_isolator_tests.cpp > 0d68dd634771c016553313d67ddb33504d1a13c2 > src/tests/containerizer/io_switchboard_tests.cpp > c3410cdbb21b974455d443a18e4af09eddea59ca > src/tests/containerizer/mesos_containerizer_tests.cpp > e61a85df6ec5308ccd2832e66df803b0ad7b53ee > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > fbd2887800ccfd64c8628c5d6fd77a511c8f91d5 > src/tests/hook_tests.cpp 542878210d0d335f504220ac21284a3239f419ee > src/tests/master_tests.cpp 7f4a8073d3ea5dd6ca5fa84171797565eb419e9b > src/tests/partition_tests.cpp eead9ceb115c84d1bc8d0d2376fa7c89dd077081 > src/tests/reconciliation_tests.cpp 671417f62536bf630c1f927cc184d108cc277a08 > src/tests/slave_recovery_tests.cpp db337ba4e213820e7ad0c3f1b480388a2e456556 > src/tests/slave_tests.cpp 9c2db7adf45af4209ecc475d938ce4b77c5a3ab4 > src/uri/fetchers/hadoop.cpp 2fa5b02ac5467a2c0c58cd024a2c8b48c4cea2f0 > > > Diff: https://reviews.apache.org/r/63568/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
