----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63491/#review190189 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/manager.cpp Lines 368-371 (patched) <https://reviews.apache.org/r/63491/#comment267467> I found a couple other spots where we indent four spaces in this situation, perhaps we should do the same here? I don't think our style guide explicitly mentions indentation of initialization lists, but the Google style guide does say: "Format a braced initializer list exactly like you would format a function call in its place." src/resource_provider/message.hpp Lines 21 (patched) <https://reviews.apache.org/r/63491/#comment267523> This is no longer needed. - Greg Mann On Nov. 6, 2017, 12:38 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63491/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2017, 12:38 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch surfaces this information to resource provider manager > users like the agent. In a later patch we will modify the agent to > forward this information to the master. > > > Diffs > ----- > > src/resource_provider/manager.cpp 11f890156f0fd099f8a97b07cdc458a0726ee78e > src/resource_provider/message.hpp 3c7c3f2baeb726e04edd6ffbb9784699d7afe521 > src/tests/slave_tests.cpp 9c2db7adf45af4209ecc475d938ce4b77c5a3ab4 > > > Diff: https://reviews.apache.org/r/63491/diff/2/ > > > Testing > ------- > > `make check`, additional testing as part of > https://reviews.apache.org/r/63496/. > > > Thanks, > > Benjamin Bannier > >
