----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63485/#review190185 -----------------------------------------------------------
Ship it! Talked with Jie offline about the use of raw ptrs here. His idea was to use a pattern conforming to the current handling of `Task*`. We agreed that this pattern has complicated ownership semantics (e.g., who calls `delete`), and that Jie would clean it up in a subsequent patch. - Benjamin Bannier On Nov. 2, 2017, 12:18 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63485/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2017, 12:18 a.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, > Greg Mann, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Added initial code for offer operation status update in master. > > > Diffs > ----- > > src/master/master.hpp 76f884c61f8d4605725e93e720dc693b861918e3 > src/master/master.cpp e047462018af50b9047b8939e922d80c4771fb28 > > > Diff: https://reviews.apache.org/r/63485/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
