----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63569/ -----------------------------------------------------------
(Updated Nov. 5, 2017, 5:20 p.m.) Review request for mesos and Andrew Schwartzmeyer. Repository: mesos Description ------- I was building Mesos with `-fsanitize=address` with Clang, and the build failed because the external dependencies were being compiled with GCC. `CMAKE_(C|CXX)_FLAGS` are already passed to the external dependencies, but `CMAKE_(C|CXX)_COMPILER` was not. This patch adds the `CMAKE_(C|CXX)_COMPILER` bits. Diffs ----- 3rdparty/CMakeLists.txt a37a8c60bc41b4bef95c79d4503e1bbe62551750 Diff: https://reviews.apache.org/r/63569/diff/1/ Testing (updated) ------- Successfully ran: ```bash cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS="-fsanitize=address" -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .. cmake --build . --target tests ``` Thanks, Michael Park
