> On Nov. 2, 2017, 8:23 p.m., Greg Mann wrote: > > 3rdparty/stout/include/stout/posix/os.hpp > > Lines 175 (patched) > > <https://reviews.apache.org/r/63422/diff/1/?file=1872796#file1872796line175> > > > > I'm curious: is there a reason you use `memset()` instead of `setenv()` > > here?
`setenv` will make the element in the environment array point to a different value but won't actually nuke an existing value. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63422/#review189954 ----------------------------------------------------------- On Oct. 30, 2017, 6:14 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63422/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2017, 6:14 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-8140 > https://issues.apache.org/jira/browse/MESOS-8140 > > > Repository: mesos > > > Description > ------- > > On Linux, updating the environment with unsetenv(3) does not > change the value that other processes can inspect (e.g. through > `/proc/$pid/environ`). Overwrite the existing value (if any) prior > to calling unsetenv(3) so we can know it is really gone. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/os.hpp > 8511dfd419a646df17eb687d732bb975f4c23d53 > > > Diff: https://reviews.apache.org/r/63422/diff/1/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
