----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63177/#review188828 -----------------------------------------------------------
Patch looks great! Reviews applied: [63177] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 20, 2017, 2:47 a.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63177/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2017, 2:47 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > The test was broken in 'de11f0ffed36fbabc8fb4167859fd23b75f43f10' > due to the executor sending one more status update. > > Additionally, an explicit verification of the status update > acknowledgement was added to eliminate a common source of > test flakyness. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp c2d9cc88a25e58887e280bbb7d3a4466525055d5 > > > Diff: https://reviews.apache.org/r/63177/diff/1/ > > > Testing > ------- > > `./mesos-tests --gtest_filter="SlaveRecoveryTest/0.RegisterDisconnectedSlave" > --break_on_failure --gtest_repeat=5000` > > > Thanks, > > Benno Evers > >
