----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62509/#review186877 -----------------------------------------------------------
Socket modification LGTM. 3rdparty/CMakeLists.txt Lines 516-518 (patched) <https://reviews.apache.org/r/62509/#comment263758> There should be two separate conditionals here: 1) `if (ENABLE_SSL)` which appends the `CMAKE_USE_OPENSSL` option. 2) `if (OPENSSL_ROOT_DIR)` which passes the hint over to curl. --- The CMake changes here don't really fit in with the contents of the rest of the patch. Consider moving these lines into a subsequent patch, like https://reviews.apache.org/r/62511/ --- Nit: Newline before and after this block. - Joseph Wu On Sept. 22, 2017, 11:21 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62509/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2017, 11:21 a.m.) > > > Review request for mesos, John Kordich, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-7992 > https://issues.apache.org/jira/browse/MESOS-7992 > > > Repository: mesos > > > Description > ------- > > This is the inverse of the existing explicit cast required for the > socket type used by libevent on Windows. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 > 3rdparty/stout/include/stout/os/windows/fd.hpp > ae2db27154e694f319dafe2e04c01d55c42179de > > > Diff: https://reviews.apache.org/r/62509/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
