> On Sept. 21, 2017, 7:42 p.m., Benjamin Mahler wrote:
> > I can't tell from the testing section, but I'll assume that you tested this 
> > by starting an agent and looking at it's ID. If not, can you please do so 
> > and follow up if there's an issue?

Also, the commit title seems to indicate there was an issue here, how about:

```
Fixed a javascript lint issue related to ellipsis in the webui.
```


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62434/#review185915
-----------------------------------------------------------


On Sept. 20, 2017, 10:32 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62434/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2017, 10:32 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7978
>     https://issues.apache.org/jira/browse/MESOS-7978
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We were previously using non-printable characters which 
> is an issue for the JavaScript linter we plan to use.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/app.js e899452d59663deac9d0166974844710c44cefce 
> 
> 
> Diff: https://reviews.apache.org/r/62434/diff/1/
> 
> 
> Testing
> -------
> 
> Change in the UI tested with Google Chrome 61.0.3163.91.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Reply via email to