----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62439/#review185794 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 155-156 (patched) <https://reviews.apache.org/r/62439/#comment262139> In general it seems that we put namespace aliases before using declarations, e.g. in `fetcher.cpp`. Please move the alias. - Jan Schlicht On Sept. 20, 2017, 4:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62439/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2017, 4:24 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > This patch introduces 'http' as an alias for 'process::http'. > > > Diffs > ----- > > src/slave/slave.cpp 01020a624bdd67ee6371f607d897ad71a2cdcc82 > > > Diff: https://reviews.apache.org/r/62439/diff/1/ > > > Testing > ------- > > Tested on a number of platforms on internal CI. > > > Thanks, > > Benjamin Bannier > >
