----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62040/#review184926 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 939-943 (original), 947-953 (patched) <https://reviews.apache.org/r/62040/#comment261122> Can you open and close the quotes on the same line? ``` if (result.isReady()) { VLOG(1) << "Successfully attached '" << path << "'" << " to virtual path '" << virtualPath << "'"; } else { LOG(ERROR) << "Failed to attach '" << path << "' << " to virtual path '" << virtualPath << "': " << (result.isFailed() ? result.failure() : "discarded"); } ``` - Benjamin Mahler On Sept. 7, 2017, 9:16 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62040/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 9:16 p.m.) > > > Review request for mesos, Benjamin Mahler and Jason Lai. > > > Bugs: MESOS-7899 > https://issues.apache.org/jira/browse/MESOS-7899 > > > Repository: mesos > > > Description > ------- > > The same physical directory will be mounted to multiple virtual paths, > so log which virtual path in agent log. > > > Diffs > ----- > > src/slave/constants.hpp 435c37e28987119c4ef43c9dad61ac052020acd8 > src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094 > src/slave/slave.cpp df920ec07cd59c7ba6baccfc1c20ed3809f187d6 > > > Diff: https://reviews.apache.org/r/62040/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
