> On Sept. 4, 2017, 1:39 p.m., Alexander Rukletsov wrote:
> > src/examples/dynamic_reservation_framework.cpp
> > Lines 366-375 (original), 366-375 (patched)
> > <https://reviews.apache.org/r/62037/diff/1/?file=1812248#file1812248line368>
> >
> > Let's use the common pattern (described in MESOS-7586) instead of this
> > blob.
Even with the new pattern, I believe that it is still useful to add this part
after logging any flag warnings:
```
if (flags.master.isNone()) {
EXIT(EXIT_FAILURE) << flags.usage("Missing --master");
} else if (flags.role.isNone()) {
EXIT(EXIT_FAILURE) << flags.usage("Missing --role");
} else if (flags.role.get() == "*") {
EXIT(EXIT_FAILURE)
<< flags.usage("Role is incorrect; the default '*' role cannot be used");
}
```
Do you agree?
- Armand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62037/#review184488
-----------------------------------------------------------
On Sept. 1, 2017, 3:47 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62037/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2017, 3:47 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
>
>
> Bugs: MESOS-7586
> https://issues.apache.org/jira/browse/MESOS-7586
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change reduces the number of messages "WARNING: Logging
> before InitGoogleLogging() is written to STDERR".
>
>
> Diffs
> -----
>
> src/checks/tcp_connect.cpp 3cb9077b9f39f69fdc152280e5b180b88e772648
> src/cli/execute.cpp e844fa46a43bdfb08246be929b7913a7997f18df
> src/cli/resolve.cpp b3cba87f61dbff0e99291775a4d0908bb35ce811
> src/examples/balloon_framework.cpp 1a97f56c3e217c58b408949306b92f19caa5f6c6
> src/examples/disk_full_framework.cpp
> f9d5af5e45d5736581ce2c5395c741c995332136
> src/examples/dynamic_reservation_framework.cpp
> bb6f58ba8fb87ae37d4ae971c192a204d5a656c5
> src/slave/container_loggers/logrotate.cpp
> 61484b18f4615e85925b26d999afb5ac3b7e32a5
> src/usage/main.cpp 5ad4a3ba7959e4a9b3fa05f5a2f49b02f94a0cf0
>
>
> Diff: https://reviews.apache.org/r/62037/diff/1/
>
>
> Testing
> -------
>
> ```
> make check
> ```
>
> Had an issue with ExamplesTest.DiskFullFramework that is not related.
>
>
> Thanks,
>
> Armand Grillet
>
>
