----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60898/#review180894 -----------------------------------------------------------
src/tests/slave_tests.cpp Lines 3327 (patched) <https://reviews.apache.org/r/60898/#comment256210> You need a corresponding `Clock::resume()`? src/tests/slave_tests.cpp Lines 3415 (patched) <https://reviews.apache.org/r/60898/#comment256213> You need a corresponding `Clock::resume()`? src/tests/slave_tests.cpp Lines 3431 (patched) <https://reviews.apache.org/r/60898/#comment256211> This comment seems wrong since you are not intercepting a registry operation. src/tests/slave_tests.cpp Lines 3440 (patched) <https://reviews.apache.org/r/60898/#comment256212> Is there a way you can set an expectation that a registry operation is not made? - James Peach On July 16, 2017, 6:29 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60898/ > ----------------------------------------------------------- > > (Updated July 16, 2017, 6:29 p.m.) > > > Review request for mesos, James Peach and Neil Conway. > > > Bugs: MESOS-7711 > https://issues.apache.org/jira/browse/MESOS-7711 > > > Repository: mesos > > > Description > ------- > > These new tests are specifically for verifying whether the registrar > is involved when an agent reregisters, depending on whether it has > been marked unreachable. > > > Diffs > ----- > > src/tests/slave_tests.cpp 053a14d1ea920058563173de7e0fa644fdbd8d96 > > > Diff: https://reviews.apache.org/r/60898/diff/2/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
