----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59130/#review179690 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp Line 170 (original), 172 (patched) <https://reviews.apache.org/r/59130/#comment254504> I like the way you did this where you validated that it's an `IPv4` below but still take the type `IP`, so let's not label this description as "IPv4" but keep it at "IP". 3rdparty/libprocess/src/process.cpp Lines 1392-1393 (patched) <https://reviews.apache.org/r/59130/#comment254505> Can we move this up to just below where we reset `__address__` please? Thanks! - Benjamin Hindman On June 29, 2017, 11:22 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59130/ > ----------------------------------------------------------- > > (Updated June 29, 2017, 11:22 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-7488 > https://issues.apache.org/jira/browse/MESOS-7488 > > > Repository: mesos > > > Description > ------- > > Added storage for IPv6 in a `libprocess` process. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 8ff37d1b5781c42f96be2da391ed000158eea7b8 > > > Diff: https://reviews.apache.org/r/59130/diff/6/ > > > Testing > ------- > > make check. > > > Thanks, > > Avinash sridharan > >
