> On May 17, 2017, 4:08 p.m., Adam B wrote: > > src/master/http.cpp > > Lines 3524 (patched) > > <https://reviews.apache.org/r/58096/diff/7/?file=1714048#file1714048line3524> > > > > `futures` is an over-vague variable name, especially since neither are > > Futures by this point. Can we do better?
I'm running out of vocabulary here... two very different thing to be captured in one word. Maybe `collection`? - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58096/#review175213 ----------------------------------------------------------- On June 22, 2017, 2 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58096/ > ----------------------------------------------------------- > > (Updated June 22, 2017, 2 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. > > > Bugs: MESOS-7260 > https://issues.apache.org/jira/browse/MESOS-7260 > > > Repository: mesos > > > Description > ------- > > While /roles displays a list of frameworksIds that register with > a role, it did NOT filter them based on VIEW_FRAMEWORK ACL, which > impose a security risk. This patch fixed this issue by taking a > frameworksApprover in `Master::Http::roles()` which is used to > filter framework IDs. > > > Diffs > ----- > > src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 > > > Diff: https://reviews.apache.org/r/58096/diff/8/ > > > Testing > ------- > > see next patch in the chain. > > > Thanks, > > Jay Guo > >
