----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59509/#review175957 -----------------------------------------------------------
Ship it! LGTM! Can you update the description with details about the reason for the flakiness i.e., what you explained to me in our offline discussion. - Anand Mazumdar On May 24, 2017, 4:15 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59509/ > ----------------------------------------------------------- > > (Updated May 24, 2017, 4:15 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-7515 > https://issues.apache.org/jira/browse/MESOS-7515 > > > Repository: mesos > > > Description > ------- > > Fixed flakiness in MasterAllocatorTest.ResourcesUnused. > > > Diffs > ----- > > src/tests/master_allocator_tests.cpp > 49d87af05d326cec00f5a9f8be5007990cfd2caa > > > Diff: https://reviews.apache.org/r/59509/diff/1/ > > > Testing > ------- > > `./src/mesos-tests --gtest_filter="MasterAllocatorTest/0.ResourcesUnused" > --gtest_repeat=2000` # OSX > `./src/mesos-tests --gtest_filter=MasterAllocatorTest/0.ResourcesUnused > --gtest_repeat=5000` # Linux > > The flakiness previously repro'd on Linux in < 100 iterations. > > > Thanks, > > Neil Conway > >
