----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review175846 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp Line 309 (original), 309 (patched) <https://reviews.apache.org/r/57817/#comment249177> I don't quite follow why you need to have this variable here? Looks like the sorter can be the source of truth of whether a role is activated or not? src/master/allocator/mesos/hierarchical.cpp Lines 348 (patched) <https://reviews.apache.org/r/57817/#comment249178> why the if? is the `sorter::activate` not idempotent? src/master/allocator/mesos/hierarchical.cpp Lines 370 (patched) <https://reviews.apache.org/r/57817/#comment249179> ditto. src/master/master.cpp Lines 2804-2808 (patched) <https://reviews.apache.org/r/57817/#comment249174> why do you need this check? is the below one not sufficient? - Vinod Kone On May 19, 2017, 6:26 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57817/ > ----------------------------------------------------------- > > (Updated May 19, 2017, 6:26 p.m.) > > > Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-7015 > https://issues.apache.org/jira/browse/MESOS-7015 > > > Repository: mesos > > > Description > ------- > > If the `SUBSCRIBE` indicates a subset of roles to be suppressed during > framework (re)registration, the allocator does not offer resources for > those roles to such frameworks. Note that this functionality is added > for `v1::SUBSCRIBE` only (and not for scheduler driver API). > > In addition, the master validates the suppressed roles to be a subset > of all the roles being (re)registered by the framework. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > dc34a1b6f0c2bdf0d653bd53394364cfa9873ca7 > src/common/protobuf_utils.hpp be2325f05b81b847fa592eff65175cbc99764fd6 > src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d > src/master/allocator/mesos/allocator.hpp > 119b461136123229f85ed3c3cfd41137974a6b9b > src/master/allocator/mesos/hierarchical.hpp > 123f97cf495bff0f822838e09df0d88818f04da6 > src/master/allocator/mesos/hierarchical.cpp > b75ed9a20a9a42f958cebbacd91e5e15b0d21394 > src/master/master.hpp 89d0790fd5fea59e74276f462581fe0073594732 > src/master/master.cpp 02affe2d6dc76ef91363df04d8d8cbed3beaf34f > src/tests/allocator.hpp 4ea722491f63f5ceda5a47228aafddc020f643b0 > src/tests/hierarchical_allocator_tests.cpp > 6dee2296d5a14185dbf7eee17968b20148839bfd > src/tests/master_allocator_tests.cpp > d05ee441a5120144aff42d78c095e1ce5051a6ac > src/tests/persistent_volume_endpoints_tests.cpp > 8c54372b7f6d94f0335561086f2a8cb90373e285 > src/tests/reservation_tests.cpp 4504831d77c1bfcf5f2ddf6d28cd45dea2c421ad > src/tests/resource_offers_tests.cpp > f0bca1d9e03013ce35215b0ffa6b50b38972dc0c > src/tests/slave_recovery_tests.cpp 52e78b6b6280a159233b402ce2849448204d4f11 > > > Diff: https://reviews.apache.org/r/57817/diff/8/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
