----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59458/#review175675 -----------------------------------------------------------
Ship it! Commit summary seems a bit confusing to me. How about "Avoided validation of agent re-registration in some cases. If the agent is still being authorized, don't bother validating the agent's re-registration message, since we are going to drop it anyway. Agent re-registration is a hot path after master failover, and validating the re-registration message is somewhat expensive." - Neil Conway On May 22, 2017, 6:12 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59458/ > ----------------------------------------------------------- > > (Updated May 22, 2017, 6:12 p.m.) > > > Review request for mesos, Neil Conway and Jiang Yan Xu. > > > Bugs: MESOS-7538 > https://issues.apache.org/jira/browse/MESOS-7538 > > > Repository: mesos > > > Description > ------- > > If we already have a re-registration in flight from this agent, we > don't need to validate the re-registration message since it will be > dropped anyway. > > > Diffs > ----- > > src/master/master.cpp e0705a532dfffd379a5bfdc3d2b095bf1c9da880 > > > Diff: https://reviews.apache.org/r/59458/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
