> On May 8, 2017, 5:22 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > > Line 235 (original), 243-244 (patched) > > <https://reviews.apache.org/r/59013/diff/1/?file=1709134#file1709134line243> > > > > I'm assuming you need `config` here explicitly and cannot get it from > > `image` below?
Correct. The `image` below is not the protobuf `Image`. It is the image class which returned from `metadata_manager`, indicating whether this image is cached or not. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/#review174253 ----------------------------------------------------------- On May 4, 2017, 4:22 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59013/ > ----------------------------------------------------------- > > (Updated May 4, 2017, 4:22 p.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Implemented passing Image::Secret Puller::pull(). > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > 344baab5c0365c3fc2dc814887bb2b48082b050f > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 5bc68d2047a7b3e3fa30315d61073e342ba6affe > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 6dacdb1403433a37dd31a93d4ff2e37d4685eb87 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp > 62ddb7a332030f3116477408d8b16c19e434c159 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 68ce265a5d0a61f8d9ed55dd14c630dcf893a7d2 > src/tests/containerizer/provisioner_docker_tests.cpp > 4341621767a9fa5be2c66e77ef60f0c65dae58ca > > > Diff: https://reviews.apache.org/r/59013/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
