----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58348/#review172794 -----------------------------------------------------------
This RR does not seem to do what the RR's summary/description says it does. Can you clarify? src/tests/environment.cpp Line 719 (original), 718 (patched) <https://reviews.apache.org/r/58348/#comment245841> Should this comment be removed/updated? - Neil Conway On April 24, 2017, 11:23 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58348/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 11:23 a.m.) > > > Review request for mesos, Neil Conway and Till Toenshoff. > > > Bugs: MESOS-7193 > https://issues.apache.org/jira/browse/MESOS-7193 > > > Repository: mesos > > > Description > ------- > > Instead of using asserts that would fail a test at runtime when > thread-safety of the test environment isn't given, these tests are now > filtered out before running the tests. > > > Diffs > ----- > > src/tests/environment.hpp 6d9a2bd451c15bb73b8018a6ad5ff04655bbec3b > src/tests/environment.cpp 3d2d8f177b2793f06d6adecfd110819bb7bbb86d > src/tests/main.cpp 5d062c3451bdfb5d5fc459ac7c071ab18e6d8043 > > > Diff: https://reviews.apache.org/r/58348/diff/2/ > > > Testing > ------- > > mesos-tests (using automake and CMake with macOS, Linux and Windows) > > > Thanks, > > Jan Schlicht > >
