> On April 11, 2017, 2:11 a.m., Adam B wrote: > > src/tests/script.cpp > > Lines 161 (patched) > > <https://reviews.apache.org/r/57730/diff/1/?file=1667156#file1667156line161> > > > > We don't even enable agent authentication in most(/any?) tests, so I'd > > expect the agents to try to register without authentication. Should we > > enable agent authentication (and authorization) by default in the tests, > > and only disable it for the rare few tests that don't need it?
Good point but this patch allows the current tests to run without making things worse. For this improvement we should probably separate the agent credentials and the framework credentials in the examples which I am happy to do. A TODO here and a followup patch sound good? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57730/#review171536 ----------------------------------------------------------- On March 17, 2017, 8:53 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57730/ > ----------------------------------------------------------- > > (Updated March 17, 2017, 8:53 a.m.) > > > Review request for mesos and Anindya Sinha. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > ------- > > - With the new `register_agents` ACL, `permissive == false` would lead > to the agent unable to register unless explicitly allowed. > > > Diffs > ----- > > src/tests/script.cpp 3b68b845b06fe19acb8b08e1ff3dd0bec9117f05 > > > Diff: https://reviews.apache.org/r/57730/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
