----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57951/#review171646 -----------------------------------------------------------
Modulo some final comments, should be ready to go... src/cli_new/README.md Lines 15-17 (original), 15-17 (patched) <https://reviews.apache.org/r/57951/#comment244630> You could leave this paragraph alone. (A whitespace change.) src/cli_new/bin/settings.py Lines 47-58 (original), 54-71 (patched) <https://reviews.apache.org/r/57951/#comment244628> Noticed a couple problems (one of which is present in the current code): * The config file FD isn't closed. * `toml.load(...)` can take a path or an FD. Might as well pass in the config path. See: https://github.com/uiri/toml/blob/e176ae93d6a7d130d260a3b1240141b8e31dfd8d/toml.py#L50 src/cli_new/bin/settings.py Line 70 (original), 84 (patched) <https://reviews.apache.org/r/57951/#comment244629> Why not raise a CLI exception if a plugin isn't found? - Joseph Wu On April 11, 2017, 7:51 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57951/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 7:51 a.m.) > > > Review request for mesos, Joseph Wu and Kevin Klues. > > > Bugs: MESOS-7269 > https://issues.apache.org/jira/browse/MESOS-7269 > > > Repository: mesos > > > Description > ------- > > These settings were previously in `settings.py`. > We now use a TOML file containing the configuration, this > format has been chosen because: > * It supports comments. > * It is well-specified. > * It allows logical grouping. > * It maps ubiquitous data types. > The config file environment variable, previously > `MESOS_CLI_CONFIG_PATH`, is now `MESOS_CLI_CONFIG`. This > change follows the design doc about the new CLI. > This environement variable `MESOS_CLI_PLUGINS` is not used > anymore as plugins can be added using the TOML file instead. > > > Diffs > ----- > > src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af > src/cli_new/bin/settings.py 2f6162edc1722054bc44ad25956e6fe666d36c7f > src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf > > > Diff: https://reviews.apache.org/r/57951/diff/4/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
