----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57925/#review171028 -----------------------------------------------------------
src/tests/slave_tests.cpp Lines 5904-5905 (patched) <https://reviews.apache.org/r/57925/#comment243860> I'm assuming the tasks also fail even if the secret generation succeeds because of the shutdown sent by the framework? If yes, should we test that as well or instead? - Vinod Kone On March 25, 2017, 6:27 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57925/ > ----------------------------------------------------------- > > (Updated March 25, 2017, 6:27 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds two further tests for executor secret > generation, `SlaveTest.RunTaskGroupReferenceTypeSecret` > and `SlaveTest.RunTaskGroupFailedSecretAfterShutdown`. > > > Diffs > ----- > > src/tests/slave_tests.cpp c31c670b667240c4876d415aa5cf90cb34273e8a > > > Diff: https://reviews.apache.org/r/57925/diff/7/ > > > Testing > ------- > > `make check` > > `bin/mesos-tests.sh --gtest_filter="SlaveTest.*Secret*" --gtest_repeat=-1 > --gtest_break_on_failure` was used to check the new tests. > > > Thanks, > > Greg Mann > >
