----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56367/#review170915 -----------------------------------------------------------
Ship it! LGTM. I can fix the below before committing. 3rdparty/stout/include/stout/os/windows/killtree.hpp Lines 54 (patched) <https://reviews.apache.org/r/56367/#comment243765> s/it/return type/ - Joseph Wu On March 31, 2017, 9:38 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56367/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 9:38 p.m.) > > > Review request for mesos, John Kordich, Joseph Wu, Li Li, and Michael Park. > > > Bugs: MESOS-6868 > https://issues.apache.org/jira/browse/MESOS-6868 > > > Repository: mesos > > > Description > ------- > > On Windows, a "process tree" is in fact a job object. Thus, the > implementation of `os::killtree` on Windows is an adapter which terminates > the job object corresponding to the process group represented by the > given PID. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/killtree.hpp > 15b2faa7b52feeb067004e9b556f06d1acfb9763 > > > Diff: https://reviews.apache.org/r/56367/diff/4/ > > > Testing > ------- > > Testing done at end of chain. > > > Thanks, > > Andrew Schwartzmeyer > >
