----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57846/#review169963 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On March 22, 2017, 7:57 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57846/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 7:57 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James > DeFelice, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-6951 > https://issues.apache.org/jira/browse/MESOS-6951 > > > Repository: mesos > > > Description > ------- > > Removes the use of `--env_file` as that does not support newlines in > environment variable values. > Removes leaking of possibly sensitive environment variables to the log. > > > Diffs > ----- > > src/docker/docker.cpp 44fbde8e8a2c6c957af7339b4fb9479af7f21ff7 > > > Diff: https://reviews.apache.org/r/57846/diff/2/ > > > Testing > ------- > > make check & sudo ./bin/mesos-tests.sh > > + functional testing > > > Thanks, > > Till Toenshoff > >
