> On March 17, 2017, 10:26 a.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp > > Lines 286 (patched) > > <https://reviews.apache.org/r/57695/diff/1/?file=1666159#file1666159line286> > > > > So, a cosequence of putting `acknowledged` inside `containers` is that > > now an unacknoweldged task wont't be sent during re-registeration if it has > > terminated and removed from `containers`. Previously, an uncknowledged task > > was sent irrespective of whether it has terminated or not. > > > > This might be ok because for a task to be removed from `containers`, > > the WAIT call should've succeeded which means the agent knows about the > > task/container. If agent knows about it, there is no need to send it during > > re-registration I think. > > > > Can you please confirm that the above is true?
Yes, this is my understanding as well. I will add a comment. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57695/#review169267 ----------------------------------------------------------- On March 16, 2017, 4:45 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57695/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 4:45 p.m.) > > > Review request for mesos, Anand Mazumdar, Gastón Kleiman, and Vinod Kone. > > > Bugs: MESOS-7249 > https://issues.apache.org/jira/browse/MESOS-7249 > > > Repository: mesos > > > Description > ------- > > Instead of maintaining a separate collection for unacknowledged tasks, > we augment internal `Container` struct by the corresponding `TaskInfo` > and `acknowledged` flag. This way we are still able to find all > unacknowledged tasks (slightly less efficiently as before since now > we have to iterate through all tasks), but also keep `TaskInfo`s > beyond receiving the first acknowledgement. > > > Diffs > ----- > > src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d > > > Diff: https://reviews.apache.org/r/57695/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
