----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review168844 -----------------------------------------------------------
src/tests/master_tests.cpp Lines 4369-4389 (patched) <https://reviews.apache.org/r/57269/#comment241086> Looks like we can do the following to simplify this: ``` JSON::Object expected = { { "frameworks", JSON::Array { JSON::Object { { "executors", JSON::Array { JSON::Object { { "role", frameworkInfo.role() } } } }, { "tasks", JSON::Array { JSON::Object { { "role", frameworkInfo.role() } } } } } } } }; EXPECT_TRUE(result.contains(expected)); ``` - Benjamin Mahler On March 13, 2017, 2:43 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57269/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 2:43 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7158 > https://issues.apache.org/jira/browse/MESOS-7158 > > > Repository: mesos > > > Description > ------- > > This test ensures that allocation roles of tasks and executors are > exposed via `/state` endpoint of master v0 API. > > > Diffs > ----- > > src/tests/master_tests.cpp cacb5566cd40ab57a9c72ad02f75e84c451d08b6 > > > Diff: https://reviews.apache.org/r/57269/diff/5/ > > > Testing > ------- > > Added a test `MasterTest.StateEndpointAllocationRole` > > make check > > > Thanks, > > Jay Guo > >
