----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54449/#review168649 -----------------------------------------------------------
Ship it! LGTM. I'll fix the following when committing. src/tests/containerizer/xfs_quota_tests.cpp Line 82 (original), 84 (patched) <https://reviews.apache.org/r/54449/#comment240888> I suggested to use `TestBase` which confirms to our naming convention better and the issue was marked resolved so I am assuming this is a typo? s/ROOT_XFS_QuotaBase/ROOT_XFS_TestBase/ src/tests/containerizer/xfs_quota_tests.cpp Lines 87 (patched) <https://reviews.apache.org/r/54449/#comment240890> s/xfsOptions/_xfsOptions/ per convention. - Jiang Yan Xu On March 10, 2017, 7:51 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54449/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 7:51 a.m.) > > > Review request for mesos, Jie Yu and Jiang Yan Xu. > > > Bugs: MESOS-6732 > https://issues.apache.org/jira/browse/MESOS-6732 > > > Repository: mesos > > > Description > ------- > > The XFS disk isolator checks that the filesystem is XFS, but doesn't > check whether project quotas are actually enabled. This means that > an invalid configuration will start but will always fail when tasks > are launched. > > Add a check to test whether project quotas are enabled on the work > directory and fail hard if they are not. > > > Diffs > ----- > > configure.ac 1e47babefa9ebd7e6fa3c23e8cb0e88bee16c671 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > dd4df86bf90bfa9cbf4664d89274cf3c64c2e374 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > 7602fe3b6ab069db643397418732e773d0417f8a > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > b9d8e7dc999ba3064bee7105eff0f9553d825df8 > src/tests/containerizer/xfs_quota_tests.cpp > 0fbaddd68af55c51c106962377be20afa599fb97 > > > Diff: https://reviews.apache.org/r/54449/diff/6/ > > > Testing > ------- > > Make check on Fedora 25. Manual test on F25 with mesos-execute. > > > Thanks, > > James Peach > >
