> On March 6, 2017, 2:18 p.m., Benjamin Mahler wrote: > > Looks good, wonder if we can just loop over the master and agent pids and > > use the same code to check the contents since they should be the same?
Yep. Thanks for the suggestion! > On March 6, 2017, 2:18 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 489-505 (patched) > > <https://reviews.apache.org/r/57336/diff/2/?file=1656657#file1656657line489> > > > > Have you tried using the contains member function to clean this up? > > > > ``` > > // We check that the following is contained within > > // the result: > > // { > > // "frameworks": > > // [ > > // { > > // "roles": ["role"] > > // } > > // ] > > // } > > ``` > > > > But since we can't do the following: > > > > ``` > > JSON::Object expected = { > > {"frameworks", { {{"roles", {"foo"} }} }} > > }; > > ``` > > > > It ends up being pretty tedious. Introduced https://reviews.apache.org/r/57354/ to allow this. > On March 6, 2017, 2:18 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 489-505 (patched) > > <https://reviews.apache.org/r/57336/diff/2/?file=1656657#file1656657line489> > > > > Do you want to guard the .as calls with some .is ASSERTs? No longer needed. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57336/#review168056 ----------------------------------------------------------- On March 6, 2017, 5:33 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57336/ > ----------------------------------------------------------- > > (Updated March 6, 2017, 5:33 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Updated `MultiRoleSchedulerUpgrade` to test framework updates. > > > Diffs > ----- > > src/tests/upgrade_tests.cpp 6cdd6d989df14af5f17b41af0bf631471feae00e > > > Diff: https://reviews.apache.org/r/57336/diff/3/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
