----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57319/#review167940 -----------------------------------------------------------
Ship it! Ship It! - Neil Conway On March 5, 2017, 3:23 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57319/ > ----------------------------------------------------------- > > (Updated March 5, 2017, 3:23 a.m.) > > > Review request for mesos, Benjamin Mahler and Neil Conway. > > > Repository: mesos > > > Description > ------- > > The issue is that we call `keys()` and `keys()` currently returns a temporary. > When we call `begin()` and `end()`, we're calling it on two different > instances. > This has unspecified behavior. > > Calling `F()` multiple times: > http://melpon.org/wandbox/permlink/cV6oxFgYldXrNwjU > Calling `F()` once: http://melpon.org/wandbox/permlink/3dtBq6S0QMQ0UHld > > > Diffs > ----- > > src/master/http.cpp 37b96c07f17d3e5ba96f6eade69d86ba9e039b3d > > > Diff: https://reviews.apache.org/r/57319/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
