> On March 2, 2017, 9:51 a.m., Jiang Yan Xu wrote: > > src/slave/main.cpp > > Lines 170 (patched) > > <https://reviews.apache.org/r/53369/diff/3/?file=1652785#file1652785line170> > > > > The following is cleaner: > > > > ``` > > Try<Nothing> assignCgroups(const string& subsystems); > > ```
I would need the other flags as well (viz. `cgroups_hierarchy` and `cgroups_root`), so I modified it as follows: `Try<Nothing> assignCgroups(const ::Flags& flags)` > On March 2, 2017, 9:51 a.m., Jiang Yan Xu wrote: > > src/slave/main.cpp > > Lines 382 (patched) > > <https://reviews.apache.org/r/53369/diff/3/?file=1652785#file1652785line382> > > > > ``` > > if (flags.agent_subsystems.isSome()) { > > Try<Nothing> assign = assignCgroups(flags.agent_subsystems.get()); > > if (assign.isError()) { > > EXIT(EXIT_FAILURE) << assign.error(); > > } > > } > > ``` Modified based on the updated signature of `Try<Nothing> assignCgroups()`. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167662 ----------------------------------------------------------- On March 2, 2017, 8:36 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53369/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 8:36 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6523 > https://issues.apache.org/jira/browse/MESOS-6523 > > > Repository: mesos > > > Description > ------- > > This is to ensure that we do not accept traffic on the agent by opening > up libprocess port only after cgroup assigment for the agent is done. > > > Diffs > ----- > > src/slave/main.cpp a124d2e0cfa3e39e2400183f9523486196b9816d > src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b > > > Diff: https://reviews.apache.org/r/53369/diff/4/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
