----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54587/#review167506 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Dec. 9, 2016, 9:29 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54587/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 9:29 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6768 > https://issues.apache.org/jira/browse/MESOS-6768 > > > Repository: mesos > > > Description > ------- > > The `ScaleTestContainerizer` and `ScaleTestExecutor` implement the basic > behaviors of a containerizer and executor while consuming no resources. > They are intended for use in scale testing a large number of agents > interacting with a master. > > The containerizer does no actual containerization nor does it actually > even run the taks. It simply runs a `ScaleTestExecutor` which sends > `TASK_RUNNING` on `Executor::launchTask()` and `TASK_KILLED` on > `Executor::killTask()`. > > Because no resources are actually consumed (but are accounted for by > the agent) any amount of resources can be offered by the agent through > `--resources` so that any desired number of tasks can be run. > > Enable it with `--containerizers=scale-test`. > > > Diffs > ----- > > src/CMakeLists.txt 0cc0451ae3ca0183da3d575cc4bd3c5b3ea30ecc > src/Makefile.am a4c03c2b918816e6dd8872d37e5208f055619c47 > src/slave/containerizer/containerizer.cpp > d46882baa904fd439bffb23c324828b777228f1c > src/slave/containerizer/scale_test/containerizer.hpp PRE-CREATION > src/slave/containerizer/scale_test/containerizer.cpp PRE-CREATION > src/slave/containerizer/scale_test/executor.hpp PRE-CREATION > src/slave/containerizer/scale_test/executor.cpp PRE-CREATION > src/tests/CMakeLists.txt 0966b7f283ea2ce646a417e81b6dfe1134a7188c > src/tests/containerizer/scale_test_containerizer_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/54587/diff/2/ > > > Testing > ------- > > Added a test to verify that `TASK_RUNNING` and `TASK_KILLED` statuses are > reported upon task "launching" and "killing". Ran `make check`. > > > Thanks, > > Ilya Pronin > >
