----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/#review166997 -----------------------------------------------------------
Ship it! Patch looks good, but this says "speeds up" but isn't this primarily fixing the flakiness? It seems to me we need a settle to ensure the timers are cleared, otherwise the future can become ready without the timers having been cleared yet. Should the summary be updated accordingly? - Benjamin Mahler On Feb. 27, 2017, 2:35 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55576/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 2:35 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin > Mahler, and Joris Van Remoortere. > > > Bugs: MESOS-6907 > https://issues.apache.org/jira/browse/MESOS-6907 > > > Repository: mesos > > > Description > ------- > > Adds calls to `Clock::pause()`, `Clock::advance()` and > `Clock::settle()` to `FutureTest.After3` so that the test > doesn't actively waits for the timers to timeout. > > This is possible since a bug that caused timers callbacks > to not always be deleted before `Clock::settle()` returned > was fixed. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/future_tests.cpp > 380755f9a2329d548969cfb2332c79aacbf7fff2 > > Diff: https://reviews.apache.org/r/55576/diff/ > > > Testing > ------- > > ```sh > # Put the machine under stress. > $ stress -c 4 -t 2600 -d 2 -i 2 & > $ ./${MESOS_SRC_ROOT}/build/3rdparty/libprocess/libprocess-tests \ > --gtest_filter="FutureTest.After3" --gtest_repeat=1000000 > --gtest_break_on_failure > $ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests > ``` > > > Thanks, > > Alexander Rojas > >
