----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57031/#review166765 -----------------------------------------------------------
Fix it, then Ship it! src/master/validation.cpp (lines 1654 - 1657) <https://reviews.apache.org/r/57031/#comment238847> We can check this after the loop only when there is a frameworkInfo. The reason is that if the operation is being applied by an operator, we are ok with the resources being unallocated. - Benjamin Mahler On Feb. 24, 2017, 10:53 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57031/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 10:53 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6636 > https://issues.apache.org/jira/browse/MESOS-6636 > > > Repository: mesos > > > Description > ------- > > With support for multi-role frameworks, we need to make sure that > individual reserve operation cannot mix allocation roles. > > > Diffs > ----- > > src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f > src/tests/master_validation_tests.cpp > 45254739e2a62fed7008ceada7a8f64bb9ee4e31 > > Diff: https://reviews.apache.org/r/57031/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
