----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56967/#review166587 -----------------------------------------------------------
Ship it! src/slave/constants.cpp (line 25) <https://reviews.apache.org/r/56967/#comment238587> I believe this goes above the namespaces here. - Benjamin Mahler On Feb. 23, 2017, 4:29 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56967/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2017, 4:29 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Instead of storing a vector of SlaveInfo::Capability::Type and convert > to Capability in the code, we switched to store a vector of Capability > directly for easier use. > > > Diffs > ----- > > src/slave/constants.hpp 753756d373a2d68dde51600bf4ec1e7985186e2c > src/slave/constants.cpp dbd2ecb146f288a4dec50bf041768fd5c4b3cb72 > src/slave/http.cpp 8a9fabf861369d3ae659dce21fa3932f6f7b9161 > src/slave/slave.cpp 45905297836017e9031359894fc71e614c13cfcc > > Diff: https://reviews.apache.org/r/56967/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
