> On Feb. 21, 2017, 9:58 p.m., Vinod Kone wrote: > > src/docker/executor.cpp, line 133 > > <https://reviews.apache.org/r/56834/diff/1/?file=1640435#file1640435line133> > > > > If termination policy is only valid for task group tasks and not normal > > tasks, we can do that validation in validation.cpp instead of here.
hmm, a termination policy can be specified for a task too by a custom executor. Also, as per our offline discussion, we need to do the validation here on the executor rather than on the master/agent. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56834/#review166237 ----------------------------------------------------------- On Feb. 20, 2017, 5:01 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56834/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2017, 5:01 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The docker/command executor currently do not support it yet. > > > Diffs > ----- > > src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8 > src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969 > > Diff: https://reviews.apache.org/r/56834/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
