----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56771/ -----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Bannier, and Greg Mann. Repository: mesos Description ------- Added regression test against fetcher SSL spillover. Diffs ----- src/tests/fetcher_tests.cpp 9c7e8b94071501c435e26850d66a8f3e8950c6cd Diff: https://reviews.apache.org/r/56771/diff/ Testing ------- Before applying RR56711: ``` [ RUN ] FetcherTest.EnvironmentSpillover W0216 23:31:25.794740 124055552 fetcher.cpp:899] Begin fetcher log (stderr in sandbox) for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 from running command: /Users/till/Development/mesos-private/build/src/mesos-fetcher I0216 23:31:25.746598 3022980032 fetcher.cpp:531] Fetcher Info: {"cache_directory":"\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/mesos\/fetch\/slaves\/","items":[{"action":"BYPASS_CACHE","uri":{"extract":true,"value":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM\/Fo2V66\/zpbEP1.gz"}}],"sandbox_directory":"\/private\/var\/folders\/_t\/rdp354gx7j5fjww270kbk6_r0000gn\/T\/KBvUlM"} I0216 23:31:25.752025 3022980032 fetcher.cpp:442] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' I0216 23:31:25.752058 3022980032 fetcher.cpp:283] Fetching directly into the sandbox directory I0216 23:31:25.752096 3022980032 fetcher.cpp:220] Fetching URI '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' I0216 23:31:25.756001 3022980032 fetcher.cpp:205] Copied resource '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/Fo2V66/zpbEP1.gz' to '/private/var/folders/_t/rdp354gx7j5fjww270kbk6_r0000gn/T/KBvUlM/zpbEP1.gz' SSL requires key! NOTE: Set path with LIBPROCESS_SSL_KEY_FILE End fetcher log for container b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9 E0216 23:31:25.795078 124055552 fetcher.cpp:555] Failed to run mesos-fetcher: Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256 ../../src/tests/fetcher_tests.cpp:1134: Failure (fetch).failure(): Failed to fetch all URIs for container 'b0fd3f0f-ae72-4d88-b8c2-b4c1af1edee9' with exit status: 256 [ FAILED ] FetcherTest.EnvironmentSpillover (115 ms) ``` After applying RR56711: ``` [ RUN ] FetcherTest.EnvironmentSpillover [ OK ] FetcherTest.EnvironmentSpillover (300 ms) ``` Thanks, Till Toenshoff
