----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review166057 -----------------------------------------------------------
Regarding the description: I'm curious how exactly the current implementation isn't compliant with RFCs 7515/7519? The one thing I noticed was the lack of support for the 'crit' header parameter. 3rdparty/libprocess/include/process/jwt.hpp (lines 44 - 48) <https://reviews.apache.org/r/56667/#comment237961> Do we want to include support for the 'crit' header parameter for spec compliance? 3rdparty/libprocess/include/process/jwt.hpp (line 77) <https://reviews.apache.org/r/56667/#comment237959> Do you think it's worth using a `JSON::Object` for the header? This would let the module accommodate arbitrary header keys (AKA 'Private Header Parameter Names' from RFC-7515), which could be useful for users who want to use the module for other purposes? 3rdparty/libprocess/src/jwt.cpp (lines 74 - 77) <https://reviews.apache.org/r/56667/#comment237962> Just one newline here? - Greg Mann On Feb. 16, 2017, 9:35 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56667/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 9:35 a.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > JSON Web Tokens can be used to create claim-based access tokens and is > typically used for HTTP authentication. > This implementation is intended for internal use, e.g. Mesos is supposed > to only parse tokens that it also created. It doesn't fully comply with > RFC 7519. Currently the only supported cryptographic algorithm is HMAC > with SHA-256. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/jwt.hpp PRE-CREATION > 3rdparty/libprocess/src/jwt.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/jwt_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/56667/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
