----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56711/#review165746 -----------------------------------------------------------
Ship it! I think we agree that since we now have three instance of this same code in the codebase (already in `src/slave/container_loggers/lib_logrotate.cpp` and in `src/slave/containerizer/mesos/io/switchboard.cpp`), we have passed an arbitrary threshold to prioritize MESOS-6751 higher, cf. http://wiki.c2.com/?ThreeStrikesAndYouRefactor. - Benjamin Bannier On Feb. 15, 2017, 4:35 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56711/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 4:35 p.m.) > > > Review request for mesos, Adam B and Benjamin Bannier. > > > Bugs: MESOS-6751 > https://issues.apache.org/jira/browse/MESOS-6751 > > > Repository: mesos > > > Description > ------- > > Fixed fetcher to not pick up environment variables it should not see. > > > Diffs > ----- > > src/slave/containerizer/fetcher.cpp > 9ec38dc95dddfcd990369d0146986e20b15da1a0 > > Diff: https://reviews.apache.org/r/56711/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
