> On Feb. 8, 2017, 10:41 a.m., Benjamin Bannier wrote: > > src/tests/master_quota_tests.cpp, line 390 > > <https://reviews.apache.org/r/52284/diff/3/?file=1626117#file1626117line390> > > > > Should we explicitly assert here that this isn't parsed as > > `cpus:2;mem:512`, e.g., > > > > ASSERT_EQ(3u, quotaResources.size());
Great catch. This actually didn't verify the case it's guarding against, because we allowed it. I've added this validation in this patch now and made this correctly rejected. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52284/#review164646 ----------------------------------------------------------- On Feb. 9, 2017, 9:40 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52284/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 9:40 p.m.) > > > Review request for mesos, Alexander Rukletsov and Xiaojian Huang. > > > Bugs: MESOS-4292 > https://issues.apache.org/jira/browse/MESOS-4292 > > > Repository: mesos > > > Description > ------- > > Implemented more quota validation tests and validate duplicate name. > > > Diffs > ----- > > src/master/quota.cpp 847ec068f4f3fe94ddabc11ff583d7e76117d375 > src/tests/master_quota_tests.cpp b25f5911579c435549b9bc65994627414357dcb6 > > Diff: https://reviews.apache.org/r/52284/diff/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
