-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55461/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 5:41 p.m.)
Review request for mesos, Benjamin Mahler, Jay Guo, and Guangya Liu.
Bugs: MESOS-6730
https://issues.apache.org/jira/browse/MESOS-6730
Repository: mesos
Description
-------
This updates the resource reservation validation for frameworks which
can have multiple roles. During a deprecation period 'FrameworkInfo'
will have fields for both 'role' and 'roles', however the validation
function works with just an optional set of roles. Here an empty set
captures the previous semantics of either having an empty 'role' field
or 'role' set as '*'. This forces the callers to properly construct a
set of framework roles from the available information. An optional set
is used in order to accommodate callers which have no information
about the framework's roles, and ultimately disables validation taking
that information into account.
Diffs (updated)
-----
src/master/master.cpp 98c39b279e7b9830d02efc8ec6a4469afc15d62a
src/master/validation.hpp fc1eaeebd0643b897f4e14aabc76e7d94f0de263
src/master/validation.cpp 2beee167439fe39d4f595c6b858fb6175321fbcd
src/tests/master_validation_tests.cpp
1f833aa8d6cacbd7bf502fb66c556e4e3d4f79e2
Diff: https://reviews.apache.org/r/55461/diff/
Testing
-------
make check
Thanks,
Benjamin Bannier
