----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/#review162963 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines 276 - 279) <https://reviews.apache.org/r/54215/#comment234339> Can you also validate the ordering with docker code? For instance, say the layer paths are: [a, b, c, d, a, e, f] will the end result be: [b, c, d, a, e, f] or [a, b, c, d, e, f] Please note that the ordering we have here in our code might not be the same as that in docker (i.e., whether base layer is to the left most or to the right most?) - Jie Yu On Jan. 24, 2017, 8:35 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54215/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 8:35 p.m.) > > > Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, Qian > Zhang, and Zhitao Li. > > > Bugs: MESOS-6654 > https://issues.apache.org/jira/browse/MESOS-6654 > > > Repository: mesos > > > Description > ------- > > This issue is exposed by pulling the 'mesosphere/inky' docker > image using registry puller. Due to the duplicate layer id > from the manifest, there are duplicate layer pathes passed > to the backend. The aufs backend cannot handle this case and > returns 'invalid arguments' error. Ideally, we should make > sure that layer paths that are passed to the backend are > unique. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > > Diff: https://reviews.apache.org/r/54215/diff/ > > > Testing > ------- > > make check > > Tested by the unit test > `ROOT_CURL_INTERNET_DockerDefaultEntryptRegistryPuller`. > > Manually tested using the `mesosphere/inky` image, which contains duplicate > layer ids. > > > Thanks, > > Gilbert Song > >
