> On Jan. 18, 2017, 1:53 p.m., Benjamin Bannier wrote: > > support/mesos-tidy.sh, line 22 > > <https://reviews.apache.org/r/55490/diff/6/?file=1607372#file1607372line22> > > > > Let's keep this further down so to not take away from `CHECKS` > > prominence. Any reason we'd want to deviate from `MESOS_DIRECTORY` used > > elsewhere? They seem to mean the same thing (extracted in slightly > > different ways). > > Michael Park wrote: > I thought here was that most (if not all) of our scripts should start > like this: > > ```bash > #!/usr/bin/env bash > > // LICENSE ... > > set -e > set -o pipefail > > MESOS_DIR=$(git rev-parse --show-toplevel) > ``` > > In terms of the use of `git`, I didn't like that I couldn't use > `$(cd "$(dirname "$0")/.." && pwd)` in scripts within deeper directories > (e.g., `support/jenkins`) because of the `..` portion of the pattern. > > It seems like the `git` command is more readable and also more portable. > > I did think about the "added" dependency on `git`, but `git` is an > essential tool, > and we would've needed `git` to end up with this repository somehow > anyway. > So I figured that shouldn't be an issue. > > Michael Park wrote: > The `s/MESOS_DIRECTORY/MESOS_DIR/` is simply because we seem to use > `_DIR` suffix for directories more widely than `DIRECTORY` in general.
Makes sense, dropping. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55490/#review162068 ----------------------------------------------------------- On Jan. 18, 2017, 9:58 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55490/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 9:58 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Used the `mesos/mesos-tidy` image from DockerHub. > > > Diffs > ----- > > support/mesos-tidy.sh 96d3ecb91f5476ff499ca5f043c527681c30efe9 > > Diff: https://reviews.apache.org/r/55490/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
