----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55458/#review162067 -----------------------------------------------------------
src/checks/checker.hpp (line 31) <https://reviews.apache.org/r/55458/#comment233316> This should be ``` Option<Error> validate(const CheckInfo& check); ``` src/checks/checker.cpp (line 45) <https://reviews.apache.org/r/55458/#comment233319> don't you want to validate that `check.command().has_command()` ? - Vinod Kone On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55458/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 9:31 a.m.) > > > Review request for mesos, Gastón Kleiman, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/CMakeLists.txt c06baf3a926687c7c6161025ae4a534dbae637e4 > src/Makefile.am 3d0e82cb522d379923e00e5e98e9c9f646fdd3db > src/checks/checker.hpp PRE-CREATION > src/checks/checker.cpp PRE-CREATION > src/master/validation.hpp 78b70a78536cd850cf56b832b575091b2e115284 > src/master/validation.cpp 5f134b781901f2de6a90fa6a10d42cc7629c27a0 > > Diff: https://reviews.apache.org/r/55458/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/55459/ > > > Thanks, > > Alexander Rukletsov > >
