> On Dec. 13, 2016, 7:29 a.m., haosdent huang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp, lines > > 54-57 > > <https://reviews.apache.org/r/54693/diff/1/?file=1582392#file1582392line54> > > > > Let's only add defintions for proto in this file.
Sure. I was initially hoping to add code for implementations, but seems like it will make the scope of this diff much bigger. I'll revert these 2 files in the diff. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/#review158963 ----------------------------------------------------------- On Dec. 13, 2016, 5:12 a.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54693/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 5:12 a.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, haosdent huang, Jie > Yu, Kunal Thakar, and Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > Add ProtoBuf schema for Blkio cgroups per the kernel Blkio controller doc. > > > Diffs > ----- > > include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/54693/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
