> On Dec. 15, 2016, 11:22 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 167 > > <https://reviews.apache.org/r/54212/diff/2/?file=1586484#file1586484line167> > > > > Do you need to create the directory first? backendDir/scratch/links > > might not exist? > > > > Don't understand why the test passes. Have you tested on a system with > > overlayfs enabled? > > Jie Yu wrote: > Have you run the test with overlayfs enabled? Please paste the test > result. THanks!
Yes, tested on Ubuntu 15: ``` [==========] Running 2 tests from 1 test case. [----------] Global test environment set-up. [----------] 2 tests from OverlayBackendTest [ RUN ] OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend [ OK ] OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackend (35 ms) [ RUN ] OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackendWithManyLayers [ OK ] OverlayBackendTest.ROOT_OVERLAYFS_OverlayFSBackendWithManyLayers (48 ms) [----------] 2 tests from OverlayBackendTest (83 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test case ran. (155 ms total) [ PASSED ] 2 tests. ``` All other test passed as well. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review159352 ----------------------------------------------------------- On Dec. 16, 2016, 10:03 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54212/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2016, 10:03 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, Qian Zhang, and Zhitao > Li. > > > Bugs: MESOS-6653 > https://issues.apache.org/jira/browse/MESOS-6653 > > > Repository: mesos > > > Description > ------- > > Since the fix of MESOS-6000, symlinks are used in overlayfs > backend to shorten the arguments when mounting the rootfs. > E.g., '.../backends/overlay/links' is the symlink created > for a provisioned image. It becomes problematic if a > container image is specified while some image volumes are > specified for the same container. An unique symlink is > needed for each image to be provisioned. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp > b71a31323aef376c9a28e1d52322a1802fb212ad > > Diff: https://reviews.apache.org/r/54212/diff/ > > > Testing > ------- > > make check > > Verified that the unit test `ROOT_ImageInVolumeWithRootFilesystem` passed. > > > Thanks, > > Gilbert Song > >
